szetszwo commented on code in PR #8691:
URL: https://github.com/apache/ozone/pull/8691#discussion_r2181087565
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/DatanodeStoreCache.java:
##########
@@ -118,11 +114,7 @@ public void shutdownCache() {
}
for (Map.Entry<String, RawDB> entry : datanodeStoreMap.entrySet()) {
- try {
- entry.getValue().getStore().stop();
- } catch (Exception e) {
- LOG.warn("Stop DatanodeStore: {} failed", entry.getKey(), e);
- }
+ entry.getValue().getStore().stop();
Review Comment:
On a second thought, getStore().stop() eventually will call the
`RDBStore.close()` method, which is either
- unRegister metrics or
- calling `IOUtils.close(..)`.
So, it should not throw any RuntimeExceptions. Let's keep the change and
iterate the values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
