jojochuang commented on code in PR #8761:
URL: https://github.com/apache/ozone/pull/8761#discussion_r2192692751
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotUtils.java:
##########
@@ -138,6 +145,7 @@ public static void createHardLinks(Path dbPath) throws
IOException {
String from = l.split("\t")[1];
String to = l.split("\t")[0];
Review Comment:
split twice is not efficient:
```suggestion
String[] parts = l.split("\t");
if (parts.length != 2) {
LOG.warn("Skipping malformed line in hardlink file: {}", l);
return;
}
String from = parts[1];
String to = parts[0];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
