nandakumar131 commented on PR #8752: URL: https://github.com/apache/ozone/pull/8752#issuecomment-3049758662
@erichung9060, thanks for working on this. Apart from unit tests, `getCurrentContainerThreshold` is used only by `getSafeModeCurrentContainerThreshold` which is exposed as JMX. The idea here is to not expose this metrics via `StorageContainerManager` class but via `SafeModeManager`. We should properly define all the metrics that will be exposed by `SafeModeManager` and add this metrics over there if it's not already present and remove it from here. Until we fix (or validate) all `SafeModeManager` metrics, I didn't want to remove this from here. The code change that's done in this PR will not be necessary as we are planning on completely removing this method in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
