bharatviswa504 commented on a change in pull request #2141:
URL: https://github.com/apache/ozone/pull/2141#discussion_r620010828
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMSecurityProtocolFailoverProxyProvider.java
##########
@@ -99,7 +100,7 @@ public
SCMSecurityProtocolFailoverProxyProvider(ConfigurationSource conf,
this.retryInterval = scmClientConfig.getRetryInterval();
}
- protected void loadConfigs() {
+ protected synchronized void loadConfigs() {
Review comment:
Do we need sychrnoize here?
As loadConfigs is called from constructor
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMSecurityProtocolFailoverProxyProvider.java
##########
@@ -99,7 +100,7 @@ public
SCMSecurityProtocolFailoverProxyProvider(ConfigurationSource conf,
this.retryInterval = scmClientConfig.getRetryInterval();
}
- protected void loadConfigs() {
+ protected synchronized void loadConfigs() {
Review comment:
Do we need synchrnoize here?
As loadConfigs is called from constructor
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMSecurityProtocolFailoverProxyProvider.java
##########
@@ -99,7 +100,7 @@ public
SCMSecurityProtocolFailoverProxyProvider(ConfigurationSource conf,
this.retryInterval = scmClientConfig.getRetryInterval();
}
- protected void loadConfigs() {
+ protected synchronized void loadConfigs() {
Review comment:
Same for all failOverProxy classes
##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure-ha/docker-config
##########
@@ -47,6 +47,7 @@ OZONE-SITE.XML_ozone.scm.client.address=scm
OZONE-SITE.XML_hdds.block.token.enabled=true
OZONE-SITE.XML_hdds.grpc.tls.enabled=true
OZONE-SITE.XML_ozone.replication=3
+OZONE-SITE.XML_hdds.scmclient.max.retry.timeout=30s
Review comment:
This will be a problem for the secure tests, as getScmInfo will retry
for 30s and fail. We want to try little longer for that as we see some failures
in test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
