ChenSammi commented on code in PR #8681:
URL: https://github.com/apache/ozone/pull/8681#discussion_r2194312685
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCExpiration.java:
##########
@@ -86,6 +100,7 @@ public void valid() throws OMException {
throw new OMException("'Days' for Expiration action must be a positive
integer greater than zero.",
OMException.ResultCodes.INVALID_REQUEST);
}
+ daysInMilli = TimeUnit.DAYS.toMillis(days);
Review Comment:
Valid() is part of initialization, it should be guranteed to be executed
before isExpired().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
