sadanand48 commented on code in PR #8453:
URL: https://github.com/apache/ozone/pull/8453#discussion_r2194387901
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java:
##########
@@ -83,7 +83,8 @@ public OMRequest preExecute(OzoneManager ozoneManager) throws
IOException {
String keyPath = keyArgs.getKeyName();
OmUtils.verifyKeyNameWithSnapshotReservedWordForDeletion(keyPath);
- keyPath = validateAndNormalizeKey(ozoneManager.getEnableFileSystemPaths(),
+ keyPath =
normalizeKeyPath(ozoneManager.getConfig().isKeyNameCharacterCheckEnabled(),
+ ozoneManager.getEnableFileSystemPaths(),
Review Comment:
please add a unit test that does:
1. mkdir("/foo:bar")
2. delete("/foo:bar")
This should fail without your patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
