Copilot commented on code in PR #8448: URL: https://github.com/apache/ozone/pull/8448#discussion_r2198914617
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolumeScannerMetrics.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.volume; + +import java.util.Collection; +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.metrics2.lib.MutableGaugeLong; + +/** + * This class captures the Storage Volume Scanner Metrics. + **/ [email protected] +@Metrics(about = "Storage Volume Scanner Metrics", context = "dfs") +public class StorageVolumeScannerMetrics { + public static final String SOURCE_NAME = StorageVolumeScannerMetrics.class.getSimpleName(); + + @Metric("number of volumes scanned in the last iteration") + private MutableGaugeLong numVolumesScannedInLastIteration; + + @Metric("number of iterations of scanner completed since the restart") + private MutableCounterLong numScanIterations; + + @Metric("number of data volume sets scanned") + private MutableGaugeLong numDataVolumesScanned; + + @Metric("number of metadata volume sets scanned") + private MutableGaugeLong numMetadataVolumesScanned; Review Comment: Similarly, use `MutableCounterLong` instead of a gauge for `numMetadataVolumesScanned` since it represents a running total of metadata-volume scans. ```suggestion private MutableCounterLong numMetadataVolumesScanned; ``` ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolumeScannerMetrics.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.volume; + +import java.util.Collection; +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.metrics2.lib.MutableGaugeLong; + +/** + * This class captures the Storage Volume Scanner Metrics. + **/ [email protected] +@Metrics(about = "Storage Volume Scanner Metrics", context = "dfs") +public class StorageVolumeScannerMetrics { + public static final String SOURCE_NAME = StorageVolumeScannerMetrics.class.getSimpleName(); + + @Metric("number of volumes scanned in the last iteration") + private MutableGaugeLong numVolumesScannedInLastIteration; + + @Metric("number of iterations of scanner completed since the restart") + private MutableCounterLong numScanIterations; + + @Metric("number of data volume sets scanned") + private MutableGaugeLong numDataVolumesScanned; Review Comment: This metric represents a cumulative count of scanned data-volume sets. It may be more appropriate to use `MutableCounterLong` instead of a gauge to reflect its counter semantics. ```suggestion private MutableCounterLong numDataVolumesScanned; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
