jojochuang commented on code in PR #8707:
URL: https://github.com/apache/ozone/pull/8707#discussion_r2199279712


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java:
##########
@@ -548,4 +549,30 @@ public <T> void buildMissingContainerSetAndValidate(Map<T, 
Long> container2BCSID
       }
     });
   }
+
+  /**
+   * Dump container metadata cache for a volume to reduce startup time.
+   */
+  public void dumpContainerCache(Iterable<? extends HddsVolume> volumes,

Review Comment:
   looks like this new public method is not covered by tests



##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java:
##########
@@ -573,6 +576,24 @@ public void stop() {
     }
   }
 
+  public void dumpContainerCache(List<StorageVolume> volumes) {

Review Comment:
   not covered by tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to