sreejasahithi commented on code in PR #8760:
URL: https://github.com/apache/ozone/pull/8760#discussion_r2203810006
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -341,12 +341,8 @@ private long estimateBucketDataSize(OmBucketInfo
bucketInfo) {
if (defRC == null) {
// Note: A lot of tests are not setting bucket DefaultReplicationConfig,
// sometimes intentionally.
- // Fall back to config default and print warning level log.
+ // Fall back to config default.
rc = ReplicationConfig.getDefault(new OzoneConfiguration());
Review Comment:
With this suggested improvement, some of the testcases fail for which we
need to stub the `getDefaultReplicationConfig()` method on the mocked
ozoneManager in those tests.
There are a couple of places where it needs to be done , so should we do
this improvement in a new follow up jira?, since the current jira's scope does
not meet this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
