devmadhuu commented on code in PR #8796:
URL: https://github.com/apache/ozone/pull/8796#discussion_r2206975085
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/UnhealthyContainersResponse.java:
##########
@@ -49,6 +49,21 @@ public class UnhealthyContainersResponse {
@JsonProperty("misReplicatedCount")
private long misReplicatedCount = 0;
+ /**
+ * .
+ */
+ @JsonProperty("firstKey")
+ private long firstKey = 0;
+
+
+ /**
+ * Total count of mis-replicated containers.
+ */
+ @JsonProperty("lastKey")
+ private long lastKey = 0;
Review Comment:
comment doesn't seem correct.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/UnhealthyContainersResponse.java:
##########
@@ -49,6 +49,21 @@ public class UnhealthyContainersResponse {
@JsonProperty("misReplicatedCount")
private long misReplicatedCount = 0;
+ /**
+ * .
+ */
+ @JsonProperty("firstKey")
+ private long firstKey = 0;
Review Comment:
empty comment..?
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -374,9 +375,9 @@ public Response getMissingContainers(
* eg UNDER_REPLICATED, MIS_REPLICATED, OVER_REPLICATED or
* MISSING. Passing null returns all containers.
* @param limit The limit of unhealthy containers to return.
- * @param batchNum The batch number (like "page number") of results to
return.
- * Passing 1, will return records 1 to limit. 2 will return
- * limit + 1 to 2 * limit, etc.
+ * @param prevStartKey startKey of previous batch. If this value is given
last N records before this container
+ * would be returned.
+ * @param prevLastKey lastKey of previous batch.
Review Comment:
same for this argument.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -374,9 +375,9 @@ public Response getMissingContainers(
* eg UNDER_REPLICATED, MIS_REPLICATED, OVER_REPLICATED or
* MISSING. Passing null returns all containers.
* @param limit The limit of unhealthy containers to return.
- * @param batchNum The batch number (like "page number") of results to
return.
- * Passing 1, will return records 1 to limit. 2 will return
- * limit + 1 to 2 * limit, etc.
+ * @param prevStartKey startKey of previous batch. If this value is given
last N records before this container
Review Comment:
Can we change the argument name to more meaningful, because this is now used
as maxContainerId. Also the comment is slightly confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
