errose28 commented on code in PR #8795: URL: https://github.com/apache/ozone/pull/8795#discussion_r2209008115
########## hadoop-hdds/docs/content/feature/multi-raft-support.md: ########## @@ -105,6 +105,22 @@ Ratis handles concurrent logs per node. The Ratis pipelines will be distributed accordingly. - Be cautious with very high pipeline counts due to memory/CPU overhead. +## Advanced Ratis Configuration + +For more fine-grained control, Ozone allows you to pass Ratis-specific settings directly from your `ozone-site.xml` configuration. This is useful for administrators and applications that need to tune Ratis performance. + +Ozone uses the prefix `hdds.ratis.` for all Ratis-related properties. When Ozone encounters a property with this prefix, it forwards the setting to the appropriate Ratis component (server or client) after removing the prefix. Review Comment: Based on a quick check I only see this happening on the datanodes. Please verify if it works for other components as this doc claims. ########## hadoop-hdds/docs/content/feature/multi-raft-support.md: ########## @@ -105,6 +105,22 @@ Ratis handles concurrent logs per node. The Ratis pipelines will be distributed accordingly. - Be cautious with very high pipeline counts due to memory/CPU overhead. +## Advanced Ratis Configuration + +For more fine-grained control, Ozone allows you to pass Ratis-specific settings directly from your `ozone-site.xml` configuration. This is useful for administrators and applications that need to tune Ratis performance. + +Ozone uses the prefix `hdds.ratis.` for all Ratis-related properties. When Ozone encounters a property with this prefix, it forwards the setting to the appropriate Ratis component (server or client) after removing the prefix. + +For example, setting `hdds.ratis.raft.grpc.message.size.max` in `ozone-site.xml` configures the Ratis property `raft.grpc.message.size.max`, which controls the maximum allowed gRPC message size. + +### Server-Side Configuration +The Ozone Manager (OM), Storage Container Manager (SCM), and Datanodes automatically load any Ratis server properties defined in `ozone-site.xml` with the `hdds.ratis.` prefix. These are typically properties that do not start with `raft.client`, `raft.client.data-stream`, or `raft.netty.dataStream`. Review Comment: I think this section is confusing. The code has no explicit filtering for the config prefixes called out here, they just would be ignored because there is no datastream usage in OM and SCM. OM and SCM do internally use Ratis clients to submit to the ring after getting a user request so `raft.client` configs would still be relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
