swamirishi commented on PR #8757: URL: https://github.com/apache/ozone/pull/8757#issuecomment-3077933624
@aryangupta1998 The check applied on KeyDeletingService is wrong to check for ratis request serialized size is wrong. We don’t send OmKeyInfo in the PurgeKeyRequest and send only the rocksdb key from deletedKeyTable. This calculation is unnecessary. We might need this check only for modified version keys but given that we would have only one OmKeyInfo in RepeatedKeyInfo we wouldn’t require any ratis serialized checks in KeyDeletingService. We should revert this patch since this would have implications on the deletion speed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
