swamirishi commented on code in PR #7365:
URL: https://github.com/apache/ozone/pull/7365#discussion_r2218772042
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -217,13 +221,13 @@ public BackgroundTaskResult call() {
LOG.debug("Running DirectoryDeletingService");
}
isRunningOnAOS.set(true);
- long rnCnt = getRunCount().incrementAndGet();
long dirNum = 0L;
long subDirNum = 0L;
long subFileNum = 0L;
long remainNum = pathLimitPerTask;
- int consumedSize = 0;
- List<PurgePathRequest> purgePathRequestList = new ArrayList<>();
+ long remainingBufLimit = ratisByteLimit;
+ List<List<PurgePathRequest>> purgeRequestListBatches = new
ArrayList<>();
Review Comment:
@sadanand48 Did we try to reproduce this scenario? This will never happen as
the rocksdb iterator is only going to read from a snapshot of the table so
newer entries added by a different thread won't be discovered by the rocksdb
iterator. We need not have introduced ratisByteLimit and could have gone ahead
with splitting the ratis request into batches instead having this obscure ratis
limit check. This check is just messy rendering the KeyManager function useless
for other purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
