errose28 commented on code in PR #8773: URL: https://github.com/apache/ozone/pull/8773#discussion_r2223649556
########## hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/TestContainerMerkleTreeWriter.java: ########## @@ -113,6 +113,103 @@ public void testBuildTreeWithMissingChunks() { assertTreesSortedAndMatch(expectedTree, actualTreeProto); } + @Test + public void testBlockIdIncludedInChecksum() { + // Create identical chunks to be used in different blocks Review Comment: The initial comment made me think chunk1 and chunk2 were supposed to be identical. This applies to the other tests as well. ```suggestion // Create a set of chunks to be used in different blocks with identical content. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org