Copilot commented on code in PR #8655:
URL: https://github.com/apache/ozone/pull/8655#discussion_r2243628503
##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -129,19 +151,20 @@
.then(function (result) {
ctrl.elapsedTime = result.data.beans[0];
if(ctrl.elapsedTime.Value != -1){
- ctrl.elapsedTime.Value =
convertMsToTime(ctrl.elapsedTime.Value);
+ ctrl.elapsedTime.Value =
ctrl.convertMsToTime(ctrl.elapsedTime.Value);
+ }
+ });
+
+ // Add JMX query to fetch DeletingServiceMetrics data
+
$http.get("jmx?qry=Hadoop:service=OzoneManager,name=DeletingServiceMetrics")
+ .then(function (result) {
+ if (result.data.beans && result.data.beans.length > 0) {
Review Comment:
Missing closing brace for the function that contains this if statement. The
function appears to be incomplete and will cause a syntax error.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java:
##########
@@ -320,7 +358,6 @@ private
OzoneManagerProtocolProtos.SetSnapshotPropertyRequest getSetSnapshotRequ
}
/**
- *
* @param currentSnapshotInfo if null, deleted directories in AOS should
be processed.
Review Comment:
The comment mentions 'deleted directories' but the method processes deleted
keys, not directories. This is misleading and should be corrected to 'deleted
keys'.
```suggestion
* @param currentSnapshotInfo if null, deleted keys in AOS should be
processed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
