Copilot commented on code in PR #8906:
URL: https://github.com/apache/ozone/pull/8906#discussion_r2258498222


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/AbstractKeyDeletingService.java:
##########
@@ -41,6 +43,7 @@
  */
 public abstract class AbstractKeyDeletingService extends BackgroundService
     implements BootstrapStateHandler {
+  public static final Logger LOG = LogManager.getLogger("OMDeletionLogger");

Review Comment:
   The logger field should be protected instead of public to maintain proper 
encapsulation while allowing access from subclasses. Public static fields can 
be modified by external classes which could break the logging mechanism.
   ```suggestion
     protected static final Logger LOG = 
LogManager.getLogger("OMDeletionLogger");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to