errose28 commented on code in PR #8914:
URL: https://github.com/apache/ozone/pull/8914#discussion_r2261281698
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/replicas/chunk/ChunkKeyHandler.java:
##########
@@ -95,8 +97,23 @@ protected void execute(OzoneClient client, OzoneAddress
address)
}
ContainerLayoutVersion containerLayoutVersion = ContainerLayoutVersion
.getConfiguredVersion(getConf());
- ArrayNode responseArrayList = result.putArray("keyLocations");
+
+ // Print opening JSON structure
+ System.out.println("{");
Review Comment:
We should use Jackson for all json generation. Mixing with manual
construction tends to be error-prone. Jackson supports streaming json to an
`OutputStream` using `SequenceWriter` and `ObjectWriter`. LLMs are also quite
good at working with Jackson to get the desired results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
