[
https://issues.apache.org/jira/browse/HDDS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013489#comment-18013489
]
Nandakumar commented on HDDS-13052:
-----------------------------------
[~szetszwo], you're right.
The ECContainerSafeModeRule has its own ecContainerDNsMap but it queries
ContainerManager to get the replicas.
The goal of HDDS-11693 is to only rely on the data from ContainerManager and
not have the same information maintained in two different places
(ECContainerSafeModeRule#ecContainerDNsMap and in ContainerManager)
After we remove the report processing logic from the SafeModeRules, we will
always call ContainerManager (ecContainerDNsMap will be removed from
ECContainerSafeModeRule).
> ECContainerSafeModeRule may incorrectly use containerManager
> -------------------------------------------------------------
>
> Key: HDDS-13052
> URL: https://issues.apache.org/jira/browse/HDDS-13052
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: SCM
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
>
> ECContainerSafeModeRule has its own ecContainerDNsMap for keeping track of
> replicas. However, it uses containerManager.getContainerReplicas(id) in the
> isMissing(..) method.
> - containerManager already have a map for container -> replicas, could we use
> it and remove ecContainerDNsMap?
> - If not, it seems that we should use ecContainerDNsMap instead of
> containerManager.getContainerReplicas(id).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
