ChenSammi commented on code in PR #8953:
URL: https://github.com/apache/ozone/pull/8953#discussion_r2292967247
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCExpiration.java:
##########
@@ -38,6 +38,7 @@
public final class OmLCExpiration implements OmLCAction {
private final Integer days;
private final String date;
+ private final ZonedDateTime createDate;
Review Comment:
@xichen01 , thanks for working on this. How about we persist this
createDate into OmLCExpiration proto, so we can assume createDate is always
there, and use it to verify the expiry date set by user, so we don't need to
decide whether it should call buildAndValid or build, leave no room for call
the function incorrectly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
