peterxcli commented on code in PR #8915:
URL: https://github.com/apache/ozone/pull/8915#discussion_r2307047156
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java:
##########
@@ -76,7 +76,7 @@ public ContainerImporter(@Nonnull ConfigurationSource conf,
this.controller = controller;
this.volumeSet = volumeSet;
this.volumeChoosingPolicy = volumeChoosingPolicy;
- containerSize = (long) conf.getStorageSize(
+ defaultContainerSize = (long) conf.getStorageSize(
Review Comment:
Sorry my bad, the container replicate size should be included in
`ReplicateContainerCommandProto` instead.
So we the replicator can know the actual size before starting choosing
volume and downloading container tar.
https://github.com/apache/ozone/blob/fce1821ce6e2c503f5a8ca88653a3e3a021c9ecf/hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto#L412-L422
https://github.com/apache/ozone/blob/fce1821ce6e2c503f5a8ca88653a3e3a021c9ecf/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReplicateContainerCommand.java#L36-L37
https://github.com/apache/ozone/blob/fce1821ce6e2c503f5a8ca88653a3e3a021c9ecf/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationTask.java#L39-L53
https://github.com/apache/ozone/blob/fce1821ce6e2c503f5a8ca88653a3e3a021c9ecf/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationTask.java#L130-L133
https://github.com/apache/ozone/blob/fce1821ce6e2c503f5a8ca88653a3e3a021c9ecf/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/DownloadAndImportReplicator.java#L58-L104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
