xichen01 commented on code in PR #8953:
URL: https://github.com/apache/ozone/pull/8953#discussion_r2312511359
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3LifecycleConfiguration.java:
##########
@@ -257,13 +257,14 @@ public OmLifecycleConfiguration
toOmLifecycleConfiguration(OzoneBucket ozoneBuck
OmLifecycleConfiguration.Builder builder = new
OmLifecycleConfiguration.Builder()
.setVolume(ozoneBucket.getVolumeName())
.setBucketLayout(ozoneBucket.getBucketLayout())
+ .setCreationTime(System.currentTimeMillis())
Review Comment:
This can be removed, OMLifecycleConfigurationSetRequest will set the
`creationTime` too.
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3LifecycleConfiguration.java:
##########
@@ -257,13 +257,14 @@ public OmLifecycleConfiguration
toOmLifecycleConfiguration(OzoneBucket ozoneBuck
OmLifecycleConfiguration.Builder builder = new
OmLifecycleConfiguration.Builder()
.setVolume(ozoneBucket.getVolumeName())
.setBucketLayout(ozoneBucket.getBucketLayout())
+ .setCreationTime(System.currentTimeMillis())
Review Comment:
This can be removed, `OMLifecycleConfigurationSetRequest` will set the
`creationTime` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
