errose28 opened a new pull request #2204: URL: https://github.com/apache/ozone/pull/2204
## What changes were proposed in this pull request? Fix race condition in NodeStateManager#addNode that gave the background pipeline creator thread a small window of time to use newly added healthy readonly nodes in pipelines. ## What is the link to the Apache JIRA HDDS-5170 ## How was this patch tested? Condition was discovered because of flaky unit test `TestSCMNodeManager#testScmLayoutOnRegister`. Without the patch, the test fails after 15-30 consecutive runs. With the patch, I was able to do 400 consecutive runs and did not see any failures. `TestSCMNodeManager#testScmLayoutOnHeartbeat` was also checked just to be safe. It is not flaky both before and after the patch based on 200 consecutive runs (which took about half an hour). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
