devabhishekpal commented on code in PR #9033:
URL: https://github.com/apache/ozone/pull/9033#discussion_r2349556211
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/overview/overview.tsx:
##########
@@ -16,31 +16,55 @@
* limitations under the License.
*/
-import React, { useEffect, useRef, useState } from 'react';
-import moment from 'moment';
-import filesize from 'filesize';
-import axios from 'axios';
+import React, { useState, useRef, useEffect } from 'react';
import { Row, Col, Button } from 'antd';
-import {
- CheckCircleFilled,
- WarningFilled
-} from '@ant-design/icons';
import { Link } from 'react-router-dom';
+import moment from 'moment';
-import AutoReloadPanel from '@/components/autoReloadPanel/autoReloadPanel';
+import OverviewSimpleCard from
'@/v2/components/overviewCard/overviewSimpleCard';
import OverviewSummaryCard from
'@/v2/components/overviewCard/overviewSummaryCard';
import OverviewStorageCard from
'@/v2/components/overviewCard/overviewStorageCard';
-import OverviewSimpleCard from
'@/v2/components/overviewCard/overviewSimpleCard';
-
-import { AutoReloadHelper } from '@/utils/autoReloadHelper';
-import { checkResponseError, showDataFetchError } from '@/utils/common';
-import { AxiosGetHelper, cancelRequests, PromiseAllSettledGetHelper } from
'@/utils/axiosRequestHelper';
-
-import { ClusterStateResponse, OverviewState, StorageReport } from
'@/v2/types/overview.types';
-
+import { AxiosGetHelper } from '@/utils/axiosRequestHelper';
+import { showDataFetchError } from '@/utils/common';
+import { cancelRequests } from '@/utils/axiosRequestHelper';
+import { useApiData } from '@/v2/hooks/useAPIData.hook';
+import { useAutoReload } from '@/v2/hooks/useAutoReload.hook';
+import AutoReloadPanel from '@/components/autoReloadPanel/autoReloadPanel';
+import { ClusterStateResponse, KeysSummary, OverviewState, TaskStatus } from
'@/v2/types/overview.types';
import './overview.less';
+import filesize from 'filesize';
+import { CheckCircleFilled, WarningFilled } from '@ant-design/icons';
+const DEFAULT_CLUSTER_STATE: ClusterStateResponse = {
Review Comment:
Addressed in the latest commit
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/overview/overview.tsx:
##########
@@ -16,31 +16,55 @@
* limitations under the License.
*/
-import React, { useEffect, useRef, useState } from 'react';
-import moment from 'moment';
-import filesize from 'filesize';
-import axios from 'axios';
+import React, { useState, useRef, useEffect } from 'react';
import { Row, Col, Button } from 'antd';
-import {
- CheckCircleFilled,
- WarningFilled
-} from '@ant-design/icons';
import { Link } from 'react-router-dom';
+import moment from 'moment';
-import AutoReloadPanel from '@/components/autoReloadPanel/autoReloadPanel';
+import OverviewSimpleCard from
'@/v2/components/overviewCard/overviewSimpleCard';
import OverviewSummaryCard from
'@/v2/components/overviewCard/overviewSummaryCard';
import OverviewStorageCard from
'@/v2/components/overviewCard/overviewStorageCard';
-import OverviewSimpleCard from
'@/v2/components/overviewCard/overviewSimpleCard';
-
-import { AutoReloadHelper } from '@/utils/autoReloadHelper';
-import { checkResponseError, showDataFetchError } from '@/utils/common';
-import { AxiosGetHelper, cancelRequests, PromiseAllSettledGetHelper } from
'@/utils/axiosRequestHelper';
-
-import { ClusterStateResponse, OverviewState, StorageReport } from
'@/v2/types/overview.types';
-
+import { AxiosGetHelper } from '@/utils/axiosRequestHelper';
+import { showDataFetchError } from '@/utils/common';
+import { cancelRequests } from '@/utils/axiosRequestHelper';
+import { useApiData } from '@/v2/hooks/useAPIData.hook';
+import { useAutoReload } from '@/v2/hooks/useAutoReload.hook';
+import AutoReloadPanel from '@/components/autoReloadPanel/autoReloadPanel';
+import { ClusterStateResponse, KeysSummary, OverviewState, TaskStatus } from
'@/v2/types/overview.types';
import './overview.less';
+import filesize from 'filesize';
+import { CheckCircleFilled, WarningFilled } from '@ant-design/icons';
+const DEFAULT_CLUSTER_STATE: ClusterStateResponse = {
+ missingContainers: 0,
+ totalDatanodes: 0,
+ healthyDatanodes: 0,
+ pipelines: 0,
+ storageReport: { capacity: 0, used: 0, remaining: 0, committed: 0 },
+ containers: 0,
+ volumes: 0,
+ buckets: 0,
+ keys: 0,
+ openContainers: 0,
+ deletedContainers: 0,
+ keysPendingDeletion: 0,
+ scmServiceId: 'N/A',
+ omServiceId: 'N/A'
+};
+const DEFAULT_TASK_STATUS: TaskStatus[] = [];
+const DEFAULT_OPEN_KEYS_SUMMARY: KeysSummary & {totalOpenKeys: number} = {
+ totalUnreplicatedDataSize: 0,
+ totalReplicatedDataSize: 0,
+ totalOpenKeys: 0
+};
+const DEFAULT_DELETE_PENDING_KEYS_SUMMARY: KeysSummary & {totalDeletedKeys:
number} = {
Review Comment:
Addressed in the latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
