peterxcli commented on code in PR #8915:
URL: https://github.com/apache/ozone/pull/8915#discussion_r2352083518
##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -549,6 +549,7 @@ message SendContainerRequest {
required bytes data = 3;
optional int64 checksum = 4;
optional CopyContainerCompressProto compression = 5;
+ optional int64 replicateSize = 6;
Review Comment:
```suggestion
optional int64 size = 6;
```
discussed with sammi and chenxi in asia community sync.
they said the "replicate" might mislead people to think it as the total size
of all container replicas. using "size" might be enough to represent its
meaning.
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -419,6 +419,7 @@ message ReplicateContainerCommandProto {
optional int32 replicaIndex = 4;
optional DatanodeDetailsProto target = 5;
optional ReplicationCommandPriority priority = 6 [default = NORMAL];
+ optional int64 replicateSize = 7;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
