errose28 commented on PR #8907:
URL: https://github.com/apache/ozone/pull/8907#issuecomment-3312935154
Hi @priyeshkaratha after looking at #8995 I think we are mostly on the same
page about this feature, but the way the doc was written was a communication
barrier.
The doc does not make a clear distinction between time series data (tracking
deletion over time) and a point-in-time view of deletion. Recon is a good spot
to have an overview of the immediate state of pending deletions, like #8995 has
currently. Additionally, it is good to expose metrics and create a grafana
dashboard to track deletion progress over time. Currently the doc frames these
as two competing ideas, when really they should both be implemented in parallel.
I suggest some improvements to the doc so others are better able to
understand the goals:
- Clarify that a Recon page only provides a point-in-time view of deletion
- Remove the current last section about Prometheus and Grafana.
- These are industry standard tools that most large production deployments
are already running for Ozone and other components in their stack as well.
- The existence of metrics and dashboards does not mean that existing
issues in Recon cannot be fixed as this section currently implies.
- Replace the Prometheus and Grafana section with an outline of what pending
delete metrics are exposed from each component, and how these can be aggregated
into a dashboard to track space usage over time.
- This should include Recon exposing metrics for things like number of
pending delete blocks + bytes in the OM DB, which are too expensive for OM to
calculate itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
