ivandika3 commented on code in PR #9060:
URL: https://github.com/apache/ozone/pull/9060#discussion_r2373818813
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v1/AbstractS3SDKV1Tests.java:
##########
@@ -758,6 +758,7 @@ public void testListMultipartUploads() {
uploadIds.add(uploadId3);
ListMultipartUploadsRequest listMultipartUploadsRequest = new
ListMultipartUploadsRequest(bucketName);
+ listMultipartUploadsRequest.setMaxUploads(5000);
MultipartUploadListing result =
s3Client.listMultipartUploads(listMultipartUploadsRequest);
Review Comment:
Let's add another case similar to `testListMultipartUploadsPagination` to
check that paging works even when bounded by initiating, say, 5000 multipart
uploads `MultipartUploadListing#maxUploads` and calling listMultipartUploads
with `maxUploads` larger than the new 1000 limit. We can check
`MultipartUploadListing#maxUploads`is bounded to 1000 and we can list the next
page, and so on.
Same can be applied to SDK V2 test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
