devmadhuu commented on code in PR #9127:
URL: https://github.com/apache/ozone/pull/9127#discussion_r2431248906
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -595,6 +593,68 @@ public void testDataSizeUnderBucketWithReplication()
throws IOException {
replicaDUResponse.getDuData().get(0).getSizeWithReplica());
}
+ @Test
+ public void testReplicatedSizePropagationUpwards() throws IOException {
Review Comment:
Yeah this is good, but this is testing only within Recon. Should we not test
using assertions based on replicated size computation in Recon and matching
using the value provided by this
[method](https://github.com/apache/ozone/blob/2f3150ab68183b8db61ee758c793fd4c1e1ee594/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/QuotaUtil.java#L47)
?
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java:
##########
Review Comment:
Pls check if these APIs will be called before NSSummary rebuild is
completed, then what is the impact ?
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/NSSummaryEndpoint.java:
##########
@@ -123,6 +124,12 @@ public Response getDiskUsage(@QueryParam("path") String
path,
return Response.ok(duResponse).build();
}
+ NSSummaryTask.RebuildState rebuildState =
ReconUtils.getNSSummaryRebuildState();
Review Comment:
Is this the the only API affected ? What about other APIs in Endpoint class ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
