Swaminathan Balachandran created HDDS-13770:
-----------------------------------------------

             Summary: SstBackup Directory can have orphan files after bootstrap 
not present in compaction log table
                 Key: HDDS-13770
                 URL: https://issues.apache.org/jira/browse/HDDS-13770
             Project: Apache Ozone
          Issue Type: Sub-task
            Reporter: Swaminathan Balachandran


Currently links from sst backup directory are created after the AOS rocksdb 
checkpoint is taken this can lead to having orphan sstFiles in backupSstFile 
directory since compactions could happen right after the checkpoints taken. 

https://github.com/apache/ozone/blob/bc731ea6af706fd51eedbc31bd1eeea0bd75c4ee/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java#L489

Rather than creating new file links the compaction log table needs to be 
iterated from the compaction log table in checkpointed rocksdb to get the 
concrete set of files that need to be copied and creating file links can be 
completely avoided. 

Redundantly copying compaction log files can also be avoided in this case.(BTW 
there should be no compaction log files in the fileSystem anywhere since the 
compaction entries would already have been loaded into compactionLogTable).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to