swamirishi commented on code in PR #9169:
URL: https://github.com/apache/ozone/pull/9169#discussion_r2441230729
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -1426,6 +1431,79 @@ public static void invalidateCacheEntry(String cacheKey)
{
}
}
+ public List<String> getCompactionLogSstFiles(Path checkpointPath)
Review Comment:
We can directly pass the checkpoint OMMetadataManager initiazed using
https://github.com/apache/ozone/blob/da030c0fac84123ff7ebd15eb3edbaf6ba0e4aff/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java#L220
and access compactionLogTable and iterate directly
https://github.com/apache/ozone/blob/da030c0fac84123ff7ebd15eb3edbaf6ba0e4aff/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java#L1668
which would avoid redundantly initializing this rocksdb open code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
