JacksonYao287 commented on pull request #2172:
URL: https://github.com/apache/ozone/pull/2172#issuecomment-834182214


   > @avijayanhwx Thanks for the review. I think we can keep the following 
check.
   > 
   > ```
   >       if (!containerExist(containerID)) {
   >         addNewContainer(containerID.getId(), containerWithPipeline);
   >       }
   > ```
   > 
   > Since the inner check @JacksonYao287 mentioned would involve additional 
write lock operations.
   
   @avijayanhwx @GlenGeng  what is your opinion
   
   > @avijayanhwx Thanks for the review. I think we can keep the following 
check.
   > 
   > ```
   >       if (!containerExist(containerID)) {
   >         addNewContainer(containerID.getId(), containerWithPipeline);
   >       }
   > ```
   > 
   > Since the inner check @JacksonYao287 mentioned would involve additional 
write lock operations.
   
   @avijayanhwx  what is you opinion about this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to