[ 
https://issues.apache.org/jira/browse/HDDS-13809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei-Chiu Chuang updated HDDS-13809:
-----------------------------------
    Description: 
OmMetadataManagerImpl.createCheckpointMetadataManager initializes a 
OmMetadataManagerImpl object, which is a Closeable subclass.
 
The objects are not closed with try..with statement. They doesn't leak 
resources because they call stop() which is equivalent to the close() method.
 
Still, it would make compiler happier if we do close instead of stop(). This is 
nice to have. Not a must do.

  was:
OmMetadataManagerImpl.createCheckpointMetadataManager initializes a 
OmMetadataManagerImpl object, which is a Closeable subclass.
 
The objects are not closed with try..with statement. They doesn't leak 
resources because they call stop() which is equivalent to the close() method.
 
Still, it would make compiler happier if we do close instead of stop().


> Close OmMetadataManagerImpl.createCheckpointMetadataManager properly
> --------------------------------------------------------------------
>
>                 Key: HDDS-13809
>                 URL: https://issues.apache.org/jira/browse/HDDS-13809
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Wei-Chiu Chuang
>            Priority: Trivial
>
> OmMetadataManagerImpl.createCheckpointMetadataManager initializes a 
> OmMetadataManagerImpl object, which is a Closeable subclass.
>  
> The objects are not closed with try..with statement. They doesn't leak 
> resources because they call stop() which is equivalent to the close() method.
>  
> Still, it would make compiler happier if we do close instead of stop(). This 
> is nice to have. Not a must do.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to