smengcl commented on code in PR #8954:
URL: https://github.com/apache/ozone/pull/8954#discussion_r2294851026
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java:
##########
@@ -426,11 +426,21 @@ public final class OMConfigKeys {
"ozone.snapshot.deleting.limit.per.task";
public static final int SNAPSHOT_DELETING_LIMIT_PER_TASK_DEFAULT = 10;
+ // Snapshot defragmentation service configuration
+ public static final String SNAPSHOT_DEFRAG_LIMIT_PER_TASK =
+ "ozone.snapshot.defrag.limit.per.task";
+ public static final int SNAPSHOT_DEFRAG_LIMIT_PER_TASK_DEFAULT = 1;
+
public static final String OZONE_SNAPSHOT_SST_FILTERING_SERVICE_INTERVAL =
"ozone.snapshot.filtering.service.interval";
public static final String
OZONE_SNAPSHOT_SST_FILTERING_SERVICE_INTERVAL_DEFAULT = "60s";
+ public static final String OZONE_SNAPSHOT_DEFRAG_SERVICE_INTERVAL =
+ "ozone.snapshot.defrag.service.interval";
+ public static final String
+ OZONE_SNAPSHOT_DEFRAG_SERVICE_INTERVAL_DEFAULT = "60s";
Review Comment:
TODO: May need to increase this interval if snapshotDiff is taking long.
Does interval countdown start only after the service run ends? I vaguely
remember that is the case. Need to double check
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java:
##########
@@ -426,11 +426,21 @@ public final class OMConfigKeys {
"ozone.snapshot.deleting.limit.per.task";
public static final int SNAPSHOT_DELETING_LIMIT_PER_TASK_DEFAULT = 10;
+ // Snapshot defragmentation service configuration
+ public static final String SNAPSHOT_DEFRAG_LIMIT_PER_TASK =
+ "ozone.snapshot.defrag.limit.per.task";
+ public static final int SNAPSHOT_DEFRAG_LIMIT_PER_TASK_DEFAULT = 1;
Review Comment:
TODO: the interval can be set to 2 or 3 later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
