Wei-Chiu Chuang created HDDS-13723:
--------------------------------------

             Summary: Add missing detailed lock information
                 Key: HDDS-13723
                 URL: https://issues.apache.org/jira/browse/HDDS-13723
             Project: Apache Ozone
          Issue Type: Improvement
            Reporter: Wei-Chiu Chuang


HDDS-8974 added detailed lock information for almost all operations that locks 
omMetadataManager lock.

where it introduced this pattern:

{code}
      mergeOmLockDetails(
          omMetadataManager.getLock().acquireWriteLock(BUCKET_LOCK, volume,
              bucket);
              bucket));
      lockAcquired = getOmLockDetails().isLockAcquired();
{code}

However looking at the usage in the latest code, it appears it missed a few 
places:

S3ExpiredMultipartUploadsAbortRequest 
https://github.com/apache/ozone/blob/5d1b43d44fa435b5a304bd1d99e8fa4a60d092cf/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3ExpiredMultipartUploadsAbortRequest.java#L204

OMDirectoriesPurgeRequestWithFSO
https://github.com/apache/ozone/blob/5d1b43d44fa435b5a304bd1d99e8fa4a60d092cf/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3ExpiredMultipartUploadsAbortRequest.java#L204

https://github.com/apache/ozone/blob/7ed9249abc6775a8aeee8169ed66faad31a3a81b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMDirectoriesPurgeRequestWithFSO.java#L171

And maybe other places as well. I don't know much about this feature so can 
only judge from the appearance.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to