jojochuang commented on code in PR #9110:
URL: https://github.com/apache/ozone/pull/9110#discussion_r2414800893
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -126,53 +126,33 @@ public Response get(
@DefaultValue("1000") @QueryParam("max-uploads") int maxUploads) throws
OS3Exception, IOException {
long startNanos = Time.monotonicNowNanos();
S3GAction s3GAction = S3GAction.GET_BUCKET;
- PerformanceStringBuilder perf = new PerformanceStringBuilder();
-
- Iterator<? extends OzoneKey> ozoneKeyIterator = null;
- ContinueToken decodedToken =
- ContinueToken.decodeFromString(continueToken);
- OzoneBucket bucket = null;
try {
+ // Handle ACL requests
if (aclMarker != null) {
- s3GAction = S3GAction.GET_ACL;
- S3BucketAcl result = getAcl(bucketName);
- getMetrics().updateGetAclSuccessStats(startNanos);
- AUDIT.logReadSuccess(
- buildAuditMessageForSuccess(s3GAction, getAuditParameters()));
- return Response.ok(result, MediaType.APPLICATION_XML_TYPE).build();
+ return handleAclRequest(bucketName, startNanos);
Review Comment:
suggest to rename as handleGetBucketAcl because it implements GetBucketAcl
https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketAcl.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
