sodonnel commented on PR #9121:
URL: https://github.com/apache/ozone/pull/9121#issuecomment-3381992893

   > For OpenKey, its valid scenario where path can not be constructed, and we 
must show those open keys,
   
   Why do we need to return the open keys? OM doesn't list open keys until they 
are committed by default. Those keys may or may not get committed, so I would 
suggest the listKeys should not include open keys at all.
   
   I am not really up to speed on the NsSummary database generation, but if the 
case is that only recently added keys can have a missing path, then it would be 
OK to skip them. The listKeys result is always lagging that from OM, and its 
constantly changing as the cluster adds / removes files. I think that is a 
better solution than just having a null path for a key sometimes. A key without 
its full path is fairly useless as it could belong anywhere on the filesystem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to