jojochuang commented on code in PR #9141:
URL: https://github.com/apache/ozone/pull/9141#discussion_r2430829663
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java:
##########
@@ -57,6 +74,13 @@ public void computeAndSetChecksum(Yaml yaml,
OmSnapshotLocalData data) throws IO
data.computeAndSetChecksum(yaml);
}
};
+ this.versionNodeMap = new HashMap<>();
+ init();
+ }
+
+ @VisibleForTesting
+ Map<UUID, SnapshotVersionsMeta> getVersionNodeMap() {
+ return versionNodeMap;
Review Comment:
should we return a unmodifiable copy here
```suggestion
return Collections.unmodifiableMap(new HashMap<>(versionNodeMap));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
