sodonnel commented on code in PR #8934:
URL: https://github.com/apache/ozone/pull/8934#discussion_r2387570218
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManagerUtil.java:
##########
@@ -178,6 +188,17 @@ An UNHEALTHY replica with unique origin node id of a
QUASI_CLOSED container shou
excludedNodes.add(r.getDatanodeDetails());
continue;
}
+ if (nodeStatus.isDead()) {
Review Comment:
Here should we add `nodeStatus.isMaintenance() && nodeStatus.isDead()`? It
is probably assumed that only a maintenance node can be dead and have still a
replica in the system, but just incase that changes we should be explicit about
it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
