fapifta commented on PR #9020: URL: https://github.com/apache/ozone/pull/9020#issuecomment-3329719634
Hi @adoroszlai thank you for the PR and the work on this, I have gone through the related RFCs, and as we discussed offline I pushed my suggestion to keep the implementation in par with the old validations by adding an extra validation that excludes IPv6 addresses that are now accepted by Commons Validator but are not accepted by BouncyCastle. I added reasaoning and relevant links to the APIDoc of the new method proposed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
