devmadhuu commented on code in PR #9127:
URL: https://github.com/apache/ozone/pull/9127#discussion_r2434650726
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketEntityHandler.java:
##########
@@ -122,25 +124,18 @@ public DUResponse getDuResponse(
DUResponse.DiskUsage diskUsage = new DUResponse.DiskUsage();
diskUsage.setSubpath(subpath);
long dataSize = getTotalSize(subdirObjectId);
- bucketDataSize += dataSize;
if (withReplica) {
long dirDU = getBucketHandler()
.calculateDUUnderObject(subdirObjectId);
Review Comment:
Also you need to update this method for OBSBucketHandler also, we do not
need old computation.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketEntityHandler.java:
##########
@@ -122,25 +124,18 @@ public DUResponse getDuResponse(
DUResponse.DiskUsage diskUsage = new DUResponse.DiskUsage();
diskUsage.setSubpath(subpath);
long dataSize = getTotalSize(subdirObjectId);
- bucketDataSize += dataSize;
if (withReplica) {
long dirDU = getBucketHandler()
.calculateDUUnderObject(subdirObjectId);
Review Comment:
This method now just retrieves size from nsSummary? Do we need this method
now ? or can we write inline ?
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketEntityHandler.java:
##########
@@ -122,25 +124,18 @@ public DUResponse getDuResponse(
DUResponse.DiskUsage diskUsage = new DUResponse.DiskUsage();
diskUsage.setSubpath(subpath);
long dataSize = getTotalSize(subdirObjectId);
Review Comment:
can `getTotalSize` method also be replaced inline ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
