symious commented on pull request #2198: URL: https://github.com/apache/ozone/pull/2198#issuecomment-836699926
@adoroszlai Thanks for the detailed clarification. If we separate the class for the delete function, I think one class should work fine for all the key and bucket generators? I didn't do that because I found that class quite dangerous, removing all the keys in a bucket or all buckets in a volume. It's like planting a bomb that can be misused by malicious people or users not familiar with the tool. So I build the clean option inside each generator making sure only the generated objects get cleaned. It's my personal view, if this is not a problem, then I'll build a separate class for the deleting function. For the performance monitoring, I think the data are deleted by datanodes asynchronously, seems we can't monitor the deletion precisely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
