swamirishi commented on code in PR #9129:
URL: https://github.com/apache/ozone/pull/9129#discussion_r2452856232
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java:
##########
@@ -351,6 +351,8 @@ private synchronized void cleanup(boolean force) {
LOG.debug("Closing SnapshotId {}. It is not being referenced
anymore.", k);
// Close the instance, which also closes its DB handle.
try {
+ // we need to explicitly flush here, close does not explicitly
do a flush
+ v.get().getMetadataManager().getStore().flushDB();
Review Comment:
Why do we need to flushDB? Please don't add unnecessary flushes? When the db
would be closed the WAL would flushed to disk anyhow. This is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
