swamirishi commented on code in PR #9131:
URL: https://github.com/apache/ozone/pull/9131#discussion_r2465306244


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
@@ -398,6 +410,29 @@ Set<Path> getSnapshotDirs(OMMetadataManager 
omMetadataManager) throws IOExceptio
     return snapshotPaths;
   }
 
+  /**
+   * Collects paths to all snapshot databases from the OM DB.
+   *
+   * @param omMetadataManager OMMetadataManager instance
+   * @return Set of paths to snapshot databases
+   * @throws IOException if an I/O error occurs
+   */
+  Set<Path> getSnapshotDirsFromDB(OMMetadataManager omMetadataManager) throws 
IOException {

Review Comment:
   table iterator is thread safe. We can get rid of getSnapshotDirs function 
and just iterate through the snapshot info table of the metadataManager instance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to