errose28 commented on code in PR #9143:
URL: https://github.com/apache/ozone/pull/9143#discussion_r2471295609
##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -31,82 +31,59 @@ option java_generate_equals_and_hash = true;
package hadoop.hdds.datanode;
/**
- * Commands that are used to manipulate the state of containers on a datanode.
- *
- * These commands allow us to work against the datanode - from
- * StorageContainer Manager as well as clients.
- *
- * 1. CreateContainer - This call is usually made by Storage Container
- * manager, when we need to create a new container on a given datanode.
- *
- * 2. ReadContainer - Allows end user to stat a container. For example
- * this allows us to return the metadata of a container.
- *
- * 3. UpdateContainer - Updates a container metadata.
-
- * 4. DeleteContainer - This call is made to delete a container.
- *
- * 5. ListContainer - Returns the list of containers on this
- * datanode. This will be used by tests and tools.
- *
- * 6. PutBlock - Given a valid container, creates a block.
- *
- * 7. GetBlock - Allows user to read the metadata of a block.
- *
- * 8. DeleteBlock - Deletes a given block.
- *
- * 9. ListBlock - Returns a list of blocks that are present inside
- * a given container.
- *
- * 10. ReadChunk - Allows us to read a chunk.
- *
- * 11. DeleteChunk - Delete an unused chunk.
- *
- * 12. WriteChunk - Allows us to write a chunk
- *
- * 13. ListChunk - Given a Container/Block returns the list of Chunks.
- *
- * 14. CompactChunk - Re-writes a chunk based on Offsets.
- *
- * 15. PutSmallFile - A single RPC that combines both putBlock and WriteChunk.
- *
- * 16. GetSmallFile - A single RPC that combines both getBlock and ReadChunk.
- *
- * 17. CloseContainer - Closes an open container and makes it immutable.
- *
- * 18. CopyContainer - Copies a container from a remote machine.
- *
- * 19. FinalizeBlock - Finalize block request from client.
+ Commands that are used to manipulate the state of containers on a datanode.
+ These commands allow us to work against the datanode - from
StorageContainerManager as well as clients.
*/
-
enum Type {
+ // This call is usually made by Storage Container manager, when we need to
create a new container on a given datanode.
Review Comment:
```suggestion
// This call is usually made by clients who will create a container which
does not already exist with the first chunk write to that container.
```
##########
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto:
##########
@@ -31,82 +31,59 @@ option java_generate_equals_and_hash = true;
package hadoop.hdds.datanode;
/**
- * Commands that are used to manipulate the state of containers on a datanode.
- *
- * These commands allow us to work against the datanode - from
- * StorageContainer Manager as well as clients.
- *
- * 1. CreateContainer - This call is usually made by Storage Container
- * manager, when we need to create a new container on a given datanode.
- *
- * 2. ReadContainer - Allows end user to stat a container. For example
- * this allows us to return the metadata of a container.
- *
- * 3. UpdateContainer - Updates a container metadata.
-
- * 4. DeleteContainer - This call is made to delete a container.
- *
- * 5. ListContainer - Returns the list of containers on this
- * datanode. This will be used by tests and tools.
- *
- * 6. PutBlock - Given a valid container, creates a block.
- *
- * 7. GetBlock - Allows user to read the metadata of a block.
- *
- * 8. DeleteBlock - Deletes a given block.
- *
- * 9. ListBlock - Returns a list of blocks that are present inside
- * a given container.
- *
- * 10. ReadChunk - Allows us to read a chunk.
- *
- * 11. DeleteChunk - Delete an unused chunk.
- *
- * 12. WriteChunk - Allows us to write a chunk
- *
- * 13. ListChunk - Given a Container/Block returns the list of Chunks.
- *
- * 14. CompactChunk - Re-writes a chunk based on Offsets.
- *
- * 15. PutSmallFile - A single RPC that combines both putBlock and WriteChunk.
- *
- * 16. GetSmallFile - A single RPC that combines both getBlock and ReadChunk.
- *
- * 17. CloseContainer - Closes an open container and makes it immutable.
- *
- * 18. CopyContainer - Copies a container from a remote machine.
- *
- * 19. FinalizeBlock - Finalize block request from client.
+ Commands that are used to manipulate the state of containers on a datanode.
+ These commands allow us to work against the datanode - from
StorageContainerManager as well as clients.
Review Comment:
I don't think SCM actually uses any of these. I think they are all provided
by clients. The docs here are probably very old and do not reflect the way the
system currently works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
