bharatviswa504 commented on a change in pull request #2229:
URL: https://github.com/apache/ozone/pull/2229#discussion_r629814512
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/ScmBlockLocationProtocolServerSideTranslatorPB.java
##########
@@ -104,7 +104,7 @@ public ScmBlockLocationProtocolServerSideTranslatorPB(
@Override
public SCMBlockLocationResponse send(RpcController controller,
SCMBlockLocationRequest request) throws ServiceException {
- if (!scm.getScmContext().isLeader()) {
+ if (!scm.checkLeader()) {
Review comment:
>>Should we separate NotLeaderException and LeaderNotReadyException ?
client should failover for the former one, and retry the same SCM for the
latter one
Good idea, let me update based on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
