sarvekshayr commented on code in PR #9217:
URL: https://github.com/apache/ozone/pull/9217#discussion_r2472350533
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/ldb/RocksDBManualCompaction.java:
##########
@@ -41,7 +41,8 @@
name = "compact",
description = "CLI to compact a column-family in the DB while the service
is offline.\n" +
"Note: If om.db is compacted with this tool then it will negatively
impact " +
- "the Ozone Manager's efficient snapshot diff.",
+ "the Ozone Manager's efficient snapshot diff." +
+ " The corresponding OM or SCM or DataNode role should be stopped for
this tool.",
Review Comment:
```suggestion
" The corresponding OM, SCM or Datanode role should be stopped for
this tool.",
```
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/quota/QuotaRepair.java:
##########
@@ -44,7 +44,7 @@
QuotaStatus.class,
QuotaTrigger.class,
},
- description = "Operational tool to repair quota in OM DB.")
+ description = "Operational tool to repair quota in OM DB." + " OM should
be running for this tool.")
Review Comment:
```suggestion
description = "Operational tool to repair quota in OM DB. OM should be
running for this tool.")
```
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/datanode/schemaupgrade/UpgradeContainerSchema.java:
##########
@@ -73,8 +73,8 @@
*/
@Command(
name = "upgrade-container-schema",
- description = "Offline upgrade all schema V2 containers to schema V3 " +
- "for this datanode.",
+ description = "Offline upgrade all schema V2 containers to schema V3 for
this datanode." +
+ " DataNode should be stopped for this command.",
Review Comment:
```suggestion
" Datanode should be stopped for this tool.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]