ivandika3 commented on code in PR #9188:
URL: https://github.com/apache/ozone/pull/9188#discussion_r2480599494
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -667,8 +667,7 @@ public static long addEpochToTxId(long epoch, long txId) {
*/
@VisibleForTesting
public static long getTxIdFromObjectId(long objectId) {
- return ((Long.MAX_VALUE >> REVERSE_EPOCH_ID_SHIFT) & objectId)
- >> TRANSACTION_ID_SHIFT;
+ return (0x3FFFFFFFFFFFFFFFL & objectId) >> TRANSACTION_ID_SHIFT;
Review Comment:
Can we revert this change? Let's not change any of the non-test code.
Btw, this does not seem to be used anymore, it seemed it was use in previous
non-ratis tests. We can remove this in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
