ivandika3 commented on code in PR #9157:
URL: https://github.com/apache/ozone/pull/9157#discussion_r2480642160
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMDirectoriesPurgeRequestWithFSO.java:
##########
@@ -255,7 +255,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, Execut
volBucketInfoMap.entrySet()) {
entry.setValue(entry.getValue().copyObject());
}
- omMetadataManager.getLock().releaseWriteLocks(BUCKET_LOCK,
bucketLockKeys);
+
mergeOmLockDetails(omMetadataManager.getLock().releaseWriteLocks(BUCKET_LOCK,
bucketLockKeys));
Review Comment:
I think we should only call `releaseWriteLocks`, if `isLockAcquired` is set
to true (similar situation in `OmKeyPurgeRequest`). @swamirishi please help to
advise here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
