jojochuang commented on code in PR #9224:
URL: https://github.com/apache/ozone/pull/9224#discussion_r2482297554
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java:
##########
Review Comment:
used by tests only.
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java:
##########
@@ -535,6 +561,26 @@ private void
addVersionsToLocalData(OmSnapshotLocalDataManager snapshotLocalData
}
}
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, 3})
+ public void testNeedsDefrag(int previousVersion) throws IOException {
+ localDataManager = new OmSnapshotLocalDataManager(omMetadataManager);
+ List<UUID> snapshotIds = createSnapshotLocalData(localDataManager, 2);
+ for (UUID snapshotId : snapshotIds) {
+ try (ReadableOmSnapshotLocalDataProvider snap =
localDataManager.getOmSnapshotLocalData(snapshotId)) {
+ assertTrue(snap.needsDefrag());
+ }
+ }
+ addVersionsToLocalData(localDataManager, snapshotIds.get(0),
ImmutableMap.of(1, 1, 2, 2, 3, 3));
+ try (ReadableOmSnapshotLocalDataProvider snap =
localDataManager.getOmSnapshotLocalData(snapshotIds.get(0))) {
+ assertFalse(snap.needsDefrag());
+ }
+ addVersionsToLocalData(localDataManager, snapshotIds.get(1),
ImmutableMap.of(1, 3, 2, previousVersion));
+ try (ReadableOmSnapshotLocalDataProvider snap =
localDataManager.getOmSnapshotLocalData(snapshotIds.get(1))) {
+ assertEquals(previousVersion <
snap.getPreviousSnapshotLocalData().getVersion(), snap.needsDefrag());
Review Comment:
when the previousSnapshotId in the yaml file is updated
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java:
##########
@@ -535,6 +561,26 @@ private void
addVersionsToLocalData(OmSnapshotLocalDataManager snapshotLocalData
}
}
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, 3})
+ public void testNeedsDefrag(int previousVersion) throws IOException {
+ localDataManager = new OmSnapshotLocalDataManager(omMetadataManager);
+ List<UUID> snapshotIds = createSnapshotLocalData(localDataManager, 2);
+ for (UUID snapshotId : snapshotIds) {
+ try (ReadableOmSnapshotLocalDataProvider snap =
localDataManager.getOmSnapshotLocalData(snapshotId)) {
+ assertTrue(snap.needsDefrag());
Review Comment:
newly created snapshots needs to defrag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
