swamirishi commented on code in PR #9229: URL: https://github.com/apache/ozone/pull/9229#discussion_r2482465741
########## hadoop-ozone/s3gateway/src/test/resources/auditlog.properties: ########## @@ -1,18 +1,18 @@ # # Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with this -# work for additional information regarding copyright ownership. The ASF -# licenses this file to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# <p> -# http://www.apache.org/licenses/LICENSE-2.0 -# <p> +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. Review Comment: Any reason why we need to change the license headers? ########## hadoop-ozone/dist/src/shell/ozone/ozone: ########## @@ -107,7 +109,7 @@ function ozonecmd_case ozone_deprecate_envvar HDDS_DN_OPTS OZONE_DATANODE_OPTS OZONE_DATANODE_OPTS="${RATIS_OPTS} ${OZONE_DATANODE_OPTS}" OZONE_DATANODE_OPTS="-Dlog4j.configurationFile=${OZONE_CONF_DIR}/dn-audit-log4j2.properties,${OZONE_CONF_DIR}/dn-container-log4j2.properties ${OZONE_DATANODE_OPTS}" - OZONE_DATANODE_OPTS="-Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector ${OZONE_DATANODE_OPTS} ${OZONE_MODULE_ACCESS_ARGS}" + OZONE_DATANODE_OPTS="${OZONE_DATANODE_OPTS} ${OZONE_MODULE_ACCESS_ARGS}" Review Comment: is synchronized default? Do you think we can use asynchornized logger for the jvm logs and use sync logger only for audit logs? Is it possible to separate this out based on the log4j properties? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
