swamirishi commented on code in PR #9212:
URL: https://github.com/apache/ozone/pull/9212#discussion_r2483106195


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyPurgeResponse.java:
##########
@@ -82,10 +87,15 @@ public void addToDBBatch(OMMetadataManager 
omMetadataManager,
     if (fromSnapshot != null) {
       OmSnapshotManager omSnapshotManager =
           ((OmMetadataManagerImpl) 
omMetadataManager).getOzoneManager().getOmSnapshotManager();
-
+      IOzoneManagerLock lock = omMetadataManager.getLock();
+      UUID fromSnapshotId = fromSnapshot.getSnapshotId();
+      OMLockDetails lockDetails = 
lock.acquireReadLock(SNAPSHOT_DB_CONTENT_LOCK, fromSnapshotId.toString());

Review Comment:
   ```
   Acquire write GC_LOCK
   Snapshot is flushed
   
      take a checkpoint on tmp path
      compact if first snapshot(kforce Compaction)
      update keyTable, fileTable, directory()
      Acquire write SNAPSHOT_DB_CONTENT_LOCK
       truncate and ingest other tables(dumpToSst and ingestSstFile)
       delete if new prodPath if exists and mv tmp to production version 
snapshotDB path
       bump version snapshotLocalDataYaml -> new versionPath
       SNapshot cache lock on snapshotId(previosu rocksdb instance)
           delete of old version of snapshot path
       release snapshot cache lock on snapshotId
      releaseWrite content Lock
   Release gc lock
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to